Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Dec 5, 2025

  • Add GET_DELIVERY_VEHICLE_ERROR_CODE constant to Android JsErrors.java
  • Update iOS error constants to match Android naming convention
  • Replace raw exception rejection with consolidated error code on Android
  • Ensure error codes and messages are identical across platforms

BREAKING CHANGE: getDeliveryVehicle error code updated to GET_DELIVERY_VEHICLE_ERROR_CODE

Fixes #2

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

- Add GET_DELIVERY_VEHICLE_ERROR_CODE constant to Android JsErrors.java
- Update iOS error constants to match Android naming convention
- Replace raw exception rejection with consolidated error code on Android
- Ensure error codes and messages are identical across platforms

Fixes #2
Copy link
Contributor

@illuminati1911 illuminati1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu merged commit 85be976 into main Dec 8, 2025
13 checks passed
@jokerttu jokerttu deleted the feat/consolidated-error-codes branch December 8, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow propagating specific error codes for GetDeliveryVehicle

3 participants